networking tests: fix ssh auth, clean up code #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix SSH auth using password. Paramiko can get confused when using password authentication while having SSH keys in the SSH agent. In case the test suite is being run using password based authentication, the options `allow_agent=False` and `look_for_key=False` prevent paramiko from trying to get keys from the SSH agent, allowing password based authentication to proceed without error. - Clean up duplicated fixture `vlan_id` and `vlan_nic`. These pytest fixtures were copy-and-pasted into several places, so to simplify the code they are consolidated in a single place where other network fixtures can be kept in the future as well. Signed-off-by: Moritz Röhrich <[email protected]>
lanfon72
requested changes
Jan 17, 2024
| # prevents paramiko from getting confused by ssh keys in the ssh | ||
| # agent: | ||
| if self.password and not self.pkey: | ||
| kws.update(dict(allow_agent=False, look_for_keys=False)) |
There was a problem hiding this comment.
The implement will implicit overwrite allow_agent and look_for_keys when call the method as
login("IP", allow_agent=True, look_for_keys=True)So please update the method signature to add parameters allow_agent and look_for_keys with default False and merge them into kws.
There was a problem hiding this comment.
Ok done, but calling login("IP", allow_agent=True, look_for_keys=True) makes no sense because the authentication will still fail if they want to use password authentication but have an SSH key in their ssh agent.
Keep in mind that some people have an SSH key in their agent that has nothing to do with these tests.
Make ssh parameters `allow_agent` and `look_for_keys` default to `False`, but let them be overridden on method call if necessary. Signed-off-by: Moritz Röhrich <[email protected]>
|
Works fine for me: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SSH auth using password. Paramiko can get confused when using password authentication while having SSH keys in the SSH agent. In case the test suite is being run using password based authentication, the options
allow_agent=Falseandlook_for_key=Falseprevent paramiko from trying to get keys from the SSH agent, allowing password based authentication to proceed without error.Clean up duplicated fixture
vlan_idandvlan_nic. These pytest fixtures were copy-and-pasted into several places, so to simplify the code they are consolidated in a single place where other network fixtures can be kept in the future as well.